[ https://issues.apache.org/jira/browse/TEZ-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562178#comment-14562178 ]
TezQA commented on TEZ-1273: ---------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12735743/TEZ-1273-9.patch against master revision fe74d6b. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 8 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/752//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/752//console This message is automatically generated. > Refactor DAGAppMaster to state machine based > -------------------------------------------- > > Key: TEZ-1273 > URL: https://issues.apache.org/jira/browse/TEZ-1273 > Project: Apache Tez > Issue Type: Improvement > Affects Versions: 0.4.0 > Reporter: Jeff Zhang > Assignee: Jeff Zhang > Attachments: DAGAppMaster_3.pdf, DAGAppMaster_4.pdf, > DAGAppMaster_5.pdf, TEZ-1273-3.patch, TEZ-1273-4.patch, TEZ-1273-5.patch, > TEZ-1273-6.patch, TEZ-1273-7.patch, TEZ-1273-8.patch, TEZ-1273-9.patch, > Tez-1273-2.patch, Tez-1273.patch, dag_app_master.pdf, dag_app_master2.pdf > > > Almost all our entities (Vertex, Task etc) are state machine based and > written using a formal state machine. But DAGAppMaster is not written on a > formal state machine even though it has a state machine based behavior. This > jira is for refactoring it into state machine based -- This message was sent by Atlassian JIRA (v6.3.4#6332)