[
https://issues.apache.org/jira/browse/TEZ-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591282#comment-14591282
]
Jeff Zhang edited comment on TEZ-2296 at 6/18/15 5:35 AM:
----------------------------------------------------------
[~saikatr] The patch mostly lgtm, but the patch seems format incorrectly. Not
sure how you generate the patch, the following things is not supposed in the
patch.
{noformat}
>From 03caa3791ddb8d0362ad5b0b26fb475302f6701c Mon Sep 17 00:00:00 2001
From: Saikat <[email protected]>
Date: Thu, 11 Jun 2015 12:20:45 -0500
Subject: [PATCH 1/2] TEZ-2296. Add option to print counters for tez-examples
(saikatr)
Signed-off-by: Saikat <[email protected]>
---
.../java/org/apache/tez/examples/HashJoinExample.java | 2 +-
.../main/java/org/apache/tez/examples/JoinDataGen.java | 2 +-
.../java/org/apache/tez/examples/OrderedWordCount.java | 2 +-
.../org/apache/tez/examples/SimpleSessionExample.java | 2 +-
.../org/apache/tez/examples/SortMergeJoinExample.java | 2 +-
.../main/java/org/apache/tez/examples/TezExampleBase.java | 15 +++++++++++++++
.../src/main/java/org/apache/tez/examples/WordCount.java | 2 +-
.../src/test/java/org/apache/tez/test/TestTezJobs.java | 14 +++++++-------
8 files changed, 28 insertions(+), 13 deletions(-)
{noformat}
And prefix is not necessary. Please ensure this in your git configuration file.
{code}
[diff]
noprefix = true
{code}
was (Author: zjffdu):
[~saikatr] The patch mostly lgtm, but the patch seems format incorrectly.
There things is not supposed in the patch.
{noformat}
>From 03caa3791ddb8d0362ad5b0b26fb475302f6701c Mon Sep 17 00:00:00 2001
From: Saikat <[email protected]>
Date: Thu, 11 Jun 2015 12:20:45 -0500
Subject: [PATCH 1/2] TEZ-2296. Add option to print counters for tez-examples
(saikatr)
Signed-off-by: Saikat <[email protected]>
---
.../java/org/apache/tez/examples/HashJoinExample.java | 2 +-
.../main/java/org/apache/tez/examples/JoinDataGen.java | 2 +-
.../java/org/apache/tez/examples/OrderedWordCount.java | 2 +-
.../org/apache/tez/examples/SimpleSessionExample.java | 2 +-
.../org/apache/tez/examples/SortMergeJoinExample.java | 2 +-
.../main/java/org/apache/tez/examples/TezExampleBase.java | 15 +++++++++++++++
.../src/main/java/org/apache/tez/examples/WordCount.java | 2 +-
.../src/test/java/org/apache/tez/test/TestTezJobs.java | 14 +++++++-------
8 files changed, 28 insertions(+), 13 deletions(-)
{noformat}
And prefix is not necessary. Please ensure this in your git configuration file.
{code}
[diff]
noprefix = true
{code}
> Add option to print counters for tez-examples
> ---------------------------------------------
>
> Key: TEZ-2296
> URL: https://issues.apache.org/jira/browse/TEZ-2296
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Jeff Zhang
> Assignee: Saikat
> Priority: Minor
> Attachments: TEZ-2296.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
