[ 
https://issues.apache.org/jira/browse/TEZ-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609935#comment-14609935
 ] 

Jeff Zhang edited comment on TEZ-2583 at 7/1/15 12:45 PM:
----------------------------------------------------------

Attach patch.

* Make RecoveryService pluggable. Use RecoveryServiceWithEventHandlingHook for 
recovery system test. Although I can add hook to RecoveryService directly 
rather than doing it in RecoveryServiceWithEventHandlingHook, it is just for 
testing, so try to make change on RecoveryService as less as possible.
* In RecoveryServiceWithEventHandlingHook allow hook to log recovery event and 
summary event so that we can control when to shutdown AM. 
* SimpleRecoveryEventHook is only for shutting down AM based on the current 
recovery event. We can implement other hook for more complicated case which may 
involve both recovery event &  summary event.
* TestRecovery has 2 simple examples to illustrate how to do recovery system 
test. I will make them ingorable now because they will cost losts of time. 


was (Author: zjffdu):
Attach patch.

* Make RecoveryService pluggable. Use RecoveryServiceWithEventHandlingHook for 
recovery system test.
* In RecoveryServiceWithEventHandlingHook allow hook to log recovery event and 
summary event so that we can control when to shutdown AM. 
* SimpleRecoveryEventHook is only for shutting down AM based on the current 
recovery event. We can implement other hook for more complicated case which may 
involve both recovery event &  summary event.
* TestRecovery has 2 simple examples to illustrate how to do recovery system 
test. I will make them ingorable now because they will cost losts of time. 

> Allow RecoveryService Pluggable 
> --------------------------------
>
>                 Key: TEZ-2583
>                 URL: https://issues.apache.org/jira/browse/TEZ-2583
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2583-1.patch, TEZ-2583-2.patch
>
>
> RecoveryService is the component to write recovery logs. The purpose of 
> allowing RecoveryService Pluggable is for recovery system test. We need to 
> control when to shutdown AM in the pluggable RecoveryService



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to