[ 
https://issues.apache.org/jira/browse/TEZ-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614467#comment-14614467
 ] 

Jeff Zhang commented on TEZ-2588:
---------------------------------

[~gliptak] Not sure how you generate the patch. But the patch format has some 
issue. 
* This is not supposed in the patch.
{noformat}
>From 4e5a810d59234f4bdea0019589da355ea50104cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?G=C3=A1bor=20Lipt=C3=A1k?= <[email protected]>
Date: Sat, 4 Jul 2015 13:06:57 -0400
Subject: [PATCH] TEZ-2588 Improper argument name in TezVertexID
{noformat}
* And prefix is not necessary. Please ensure this in your git configuration 
file.
{code}
[diff]
    noprefix = true
{code}


> Inproper argument name
> ----------------------
>
>                 Key: TEZ-2588
>                 URL: https://issues.apache.org/jira/browse/TEZ-2588
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Jeff Zhang
>            Assignee: Gabor Liptak
>            Priority: Trivial
>              Labels: newbie
>         Attachments: TEZ-2588.1.patch
>
>
> TezVertexID.java
> {code}
> public static TezVertexID fromString(String taskIdStr) {  // should be 
> vertexIdStr
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to