[
https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618507#comment-14618507
]
Rajesh Balamohan commented on TEZ-2591:
---------------------------------------
lgtm from patch perspective. Only concern is
- Patch pushes legacy API to EdgeManagerPlugin, but also removes the routing
logic from existing code as a part of cleanup/separation. In case (for any
reason) the legacy routing needs to be looked at, this calls for new
implementation. Would be good to get other folk's pov as well.
> Remove unneeded methods from EdgeManagerPludinOnDemand
> ------------------------------------------------------
>
> Key: TEZ-2591
> URL: https://issues.apache.org/jira/browse/TEZ-2591
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch, TEZ-2591.3.patch
>
>
> EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some
> common methods. Removing this dependency would be cleaner for the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
