[ 
https://issues.apache.org/jira/browse/TEZ-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636249#comment-14636249
 ] 

Bikas Saha commented on TEZ-2634:
---------------------------------

code mostly looks good to me.
About the test, its probably importing unneeded stuff like DOWNLOAD_DIR. Also, 
could this test be run in local mode instead and write to the test working dir. 
I am wary that /tmp/xyz might not work on windows for unit tests. Also this 
would make the test go faster. Alternatively we could use some of the existing 
minicluster tests that run wordcount or orderedwordcount (and reuse their 
simple history log) instead of running another test that would increase the 
build time by 30s or more. (e.g. Union test) it does not need input file 
generation because it does not read external input).

> Provide SimpleHistoryParser to parse SimpleHistoryLog and normalize to 
> in-memory datamodel provided in tez-history
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-2634
>                 URL: https://issues.apache.org/jira/browse/TEZ-2634
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>         Attachments: TEZ-2634.1.patch
>
>
> Would be useful when only SimpleHistoryLogging is available & ATS data is not 
> available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to