[
https://issues.apache.org/jira/browse/TEZ-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643220#comment-14643220
]
Hitesh Shah commented on TEZ-2627:
----------------------------------
Comments:
- the log debug message in the createAppSubmCtxt function can likely be
removed and moved to the setApplicationPriority function. Something simple like
"Settting application priority, applicationId=<appId>, priority=<priority>"
- add a comment to explain why 0 will not be used in "int priority =
amConfig.getTezConfiguration().getInt(TezConfiguration.TEZ_AM_APPLICATION_PRIORITY,0);"
- setApplicationPriority should have a VisibleForTesting annotation
- rename testAppSubmissionContext to something more relevant to what it is
doing i.e. testing app priority. Given that a call to YARN is not being made, a
single priority value check ( +999 ) or something should suffice.
- not sure why a compareTo is needed to compare 2 ints for the priority
comparison. Maybe just use Priority::getPriority() which is an int?
- Simpler to just use "TezConfiguration conf = new TezConfiguration(false);"
instead of a mock.
- Likewise for AMConfiguration.
- TestTezJobs.java code change should use a non-zero value for priority
> Support for Tez Job Priorities
> ------------------------------
>
> Key: TEZ-2627
> URL: https://issues.apache.org/jira/browse/TEZ-2627
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Saikat
> Assignee: Saikat
> Attachments: TEZ-2627.1.patch, TEZ-2627.2.patch, TEZ-2627.3.patch,
> TEZ-2627.patch
>
>
> When a Tez Job is submitted via TezClient, an ApplicationSubmissionContext is
> created before submitting the job. ApplicationSubmissionContext has a
> priority field which can be used to provide a priority for the job.
> There is an ongoing effort in the Yarn Community to enable application
> priorities(https://issues.apache.org/jira/browse/YARN-1963).
> https://issues.apache.org/jira/browse/YARN-2003 implements the necessary
> changes in RM and Capacity Scheduler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
