[
https://issues.apache.org/jira/browse/TEZ-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659692#comment-14659692
]
Jeff Zhang edited comment on TEZ-2004 at 8/10/15 10:39 AM:
-----------------------------------------------------------
Comments:
* Is ContainerOp necessary ? It seems ContainerLauncherOperationBase can be
used instead, just need to move OPType into ContainerLauncherOperationBase,
how about rename it as ContainerOperationBase ?
* TaskCommunicator.java Rename unregisterRunningTaskAttempt to
registerTaskAttemptEnd (make it more consistent)
* Rename ContainerLauncherImpl to TezContainerLauncherImpl ? Make all the
default implementation with prefix Tez ?
* Typo DagTypeConverters.convertServicePluginDescriptoToProto -->
DagTypeConverters.convertServicePluginDescriptorToProto (miss "r")
* Need to verify the DAG's defaultExecutionContext and Vertex's
ExecutionContext exist in the TezClient.servicePluginsDescriptor when
submitting the dag
* Need to verify VertexExecutionContext's executeInAm & executeInContainers is
supported in TezClient's ServicePluginsDescriptor
* Seems currently there's only programmatic way to specify TaskScheduler,
ContainerLauncher, TaskCommunicator through TezClient's
ServicePluginsDescriptor, is it expected ? That would mean if some third party
want to introduce new external service to hive, not only they need to implement
new TaskScheduler, ContainerLauncher, TaskCommunicator but also need to change
hive code and rebuild.
* ServicePluginsDescriptor
As my understanding, TaskSchduler/TaskCommunicator/ContainerLauncher are
used together, can not be combined arbitrarily. So should we use
ExecutionContextDescriptor to replace the 3 separators descriptors ?
* TaskAttempt#scheduleTime may need to put into history event
TaskAttemptStartedEvent to be used by Tez-UI
was (Author: zjffdu):
Comments:
* Is ContainerOp necessary ? It seems ContainerLauncherOperationBase can be
used instead, just need to move OPType into ContainerLauncherOperationBase,
how about rename it as ContainerOperationBase ?
* TaskCommunicator.java Rename unregisterRunningTaskAttempt to
registerTaskAttemptEnd (make it more consistent)
* Rename ContainerLauncherImpl to TezContainerLauncherImpl ? Make all the
default implementation with prefix Tez ?
* Typo DagTypeConverters.convertServicePluginDescriptoToProto -->
DagTypeConverters.convertServicePluginDescriptorToProto (miss "r")
* Need to verify the DAG's defaultExecutionContext and Vertex's
ExecutionContext exist in the TezClient.servicePluginsDescriptor when
submitting the dag
* Need to verify VertexExecutionContext's executeInAm & executeInContainers is
supported in TezClient's ServicePluginsDescriptor
* Seems currently there's only programmatic way to specify TaskScheduler,
ContainerLauncher, TaskCommunicator through TezClient's
ServicePluginsDescriptor, is it expected ? That would mean if some third party
want to introduce new external service to hive, not only they need to implement
new TaskScheduler, ContainerLauncher, TaskCommunicator but also need to change
hive code and rebuild.
> Define basic interface for pluggable ContainerLaunchers
> -------------------------------------------------------
>
> Key: TEZ-2004
> URL: https://issues.apache.org/jira/browse/TEZ-2004
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: TEZ-2003
>
> Attachments: TEZ-2004.1.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
