[
https://issues.apache.org/jira/browse/TEZ-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680817#comment-14680817
]
Bikas Saha commented on TEZ-2692:
---------------------------------
Do we need firstTasktoFinish or firstTaskToStart? If the latter, then should we
be using dag.getStartTime() or vertex.getStartTime() ?
{code}+ private long getTaskRuntime(VertexInfo vertexInfo) {
+ TaskInfo firstTaskToFinish = vertexInfo.getFirstTaskToStart();
+ TaskInfo lastTaskToFinish = vertexInfo.getLastTaskToFinish();
+
+ DagInfo dagInfo = vertexInfo.getDagInfo();
+ long totalTime = ((lastTaskToFinish == null) ?
+ dagInfo.getFinishTime() : lastTaskToFinish.getFinishTime()) -
+ ((firstTaskToFinish == null) ? dagInfo.getFinishTime() :
firstTaskToFinish.getFinishTime());
+ return totalTime;
}{code}
The concurrency calculator logic could be improved a bit. E.g. if we arrange
all start and stop timestampts in a sorted order as - St1, St2, Et3, Et4. Then
we can walk this list to produce concurrency as - (t1, 1), (t2, 2), (t3, 1),
(t4, 0). If this logic is correct, we could do it here or in a follow up jira.
If possible, can the new test be merged into the existing ATS parser test. This
would reuse code and also reduce test run time by reusing the same mini cluster.
Rest looks good!
> bugfixes & enhancements related to job parser and analyzer
> ----------------------------------------------------------
>
> Key: TEZ-2692
> URL: https://issues.apache.org/jira/browse/TEZ-2692
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Rajesh Balamohan
> Assignee: Rajesh Balamohan
> Attachments: TEZ-2692.1.patch, TEZ-2692.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
