[ 
https://issues.apache.org/jira/browse/TEZ-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702036#comment-14702036
 ] 

Hitesh Shah commented on TEZ-2164:
----------------------------------

You will need to compile guava-tez first - it is not part of the top-level 
module list. 

bq.  Does the shade plugin allow usage of the original package names in code, 
and have the shading done post compile ?

I tried that approach but was not successful due to a set of reasons:
   - the relocation happens on jar creation
   - unit tests in other modules when referencing internal apis using guava 
breaks as they use normal guava packages and not the relocated ones
   - the only seamless way to do this is create a fat jar in tez-dist assembly 
with all guava relocated. However this still does not solve the case where tez 
wants to use a newer guava version. 

And yes, we will need to monitor each patch to see that com.google does not 
creep in - which is a possibility given that we cannot remove guava-11 as a 
compile time dependency ( caused by hadoop yarn using guava objects in its apis 
)  

> Shade the guava version used by Tez
> -----------------------------------
>
>                 Key: TEZ-2164
>                 URL: https://issues.apache.org/jira/browse/TEZ-2164
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Hitesh Shah
>            Priority: Critical
>         Attachments: TEZ-2164.3.patch, TEZ-2164.wip.2.patch, 
> allow-guava-16.0.1.patch
>
>
> Should allow us to upgrade to a newer version without shipping a guava 
> dependency.
> Would be good to do this in 0.7 so that we stop shipping guava as early as 
> possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to