[ 
https://issues.apache.org/jira/browse/TEZ-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705642#comment-14705642
 ] 

Siddharth Seth edited comment on TEZ-2164 at 8/20/15 7:50 PM:
--------------------------------------------------------------

If we're taking this approach, I think we'll have to publish the guava-tez jar 
into a repository. Changing the build step to first compile guava-tez and then 
run the mvn install command would be a terrible experience.

This also means any project which depends on Tez will end up seeing two 
versions of Guava classes - which can lead to accidental usage of the tez 
version.
I'm not sure about this, but we may be able to continue depending on guava, and 
set the dependency to optional - so that downstream components do not 
automatically get the dependency. Don't think it's possible to set this for 
guava-tez though.

Should guava-tez reside in tez-tools, or some such sub-module.


was (Author: sseth):
If we're taking this approach, I think we'll have to publish the guava-tez jar 
into a repository. Changing the build step to first compile guava-tez and then 
run the mvn install command would be a terrible experience.

This also means any project which depends on Tez will end up seeing two 
versions of Guava classes - which can lead to accidental usage of the tez 
version.
I'm not sure about this, but we may be able to continue depending on guava, and 
set the dependency to optional - so that downstream components do not 
automatically get the dependency. Don't think it's possible to set this for 
guava-tez though.

Should guava-tez reside in tez-tools, or some such sub-package.

> Shade the guava version used by Tez
> -----------------------------------
>
>                 Key: TEZ-2164
>                 URL: https://issues.apache.org/jira/browse/TEZ-2164
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Hitesh Shah
>            Priority: Critical
>         Attachments: TEZ-2164.3.patch, TEZ-2164.wip.2.patch, 
> allow-guava-16.0.1.patch
>
>
> Should allow us to upgrade to a newer version without shipping a guava 
> dependency.
> Would be good to do this in 0.7 so that we stop shipping guava as early as 
> possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to