[
https://issues.apache.org/jira/browse/TEZ-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706254#comment-14706254
]
Rajesh Balamohan commented on TEZ-2732:
---------------------------------------
Attaching the patch for review. [~hitesh], [~sseth] - Please review when you
find time.
- Capping buffer to 1800.
- Added tests which would reproduce this issue with
DefaultSorter.MAX_IO_SORT_MB=2047 and when io.sort.mb is set to 2047.
- Disabled these tests by default as it would need > 2 GB containers in test
env.
> DefaultSorter throws ArrayIndex exceptions on 2047 Mb size sort buffers
> -----------------------------------------------------------------------
>
> Key: TEZ-2732
> URL: https://issues.apache.org/jira/browse/TEZ-2732
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Rajesh Balamohan
> Assignee: Rajesh Balamohan
> Attachments: TEZ-2732.1.patch
>
>
> {noformat}
> kvbuffer.length = 2146435072 (2047 MB)
> Corner case: bufIndex=2026133899, kvbidx=523629312.
> distkvi = mod - i + j = 2146435072 - 2026133899 + 523629312 = 643930485
> newPos = (2026133899 + (max(.., min(643930485/2, 271128624))) (This would
> overflow)
> {noformat}
> Would be good to restrict the max allowed sort buffer to 1800 instead of
> 2047.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
