[
https://issues.apache.org/jira/browse/TEZ-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706701#comment-14706701
]
Rajesh Balamohan commented on TEZ-2690:
---------------------------------------
lgtm. +1.
Very minor comments
{noformat}
Option dagIdOption = OptionBuilder.withArgName(DAG_ID).withLongOpt(DAG_ID)
.withDescription("DagId that needs to be
downloaded").hasArg().isRequired(true).create();
{noformat}
- Was referring to the description in earlier comment. Initially it gave a
perception that, this would also download the DagId and start analyzing. Should
it be changed as "DagId that needs to be analyzed" ?
- In SVGUtils, can "DecimalFormat" be declared at the beginning, so that it
can be used across invocations?
- In VertexInfo, is it possible that totalAttempts can be 0 due to some error
or some empty task; and it can throw dividebyzero exception?. Should we check
for getTasks().size() > 0
> Add critical path analyser
> --------------------------
>
> Key: TEZ-2690
> URL: https://issues.apache.org/jira/browse/TEZ-2690
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2690.1.patch, TEZ-2690.2.patch, TEZ-2690.3.patch,
> TEZ-2690.4.patch, criticalPath.jpg, dag_1439860407967_0030_1.svg
>
>
> Use input and scheduling dependencies to create critical path for a DAG.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
