[
https://issues.apache.org/jira/browse/TEZ-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715614#comment-14715614
]
Hitesh Shah commented on TEZ-2749:
----------------------------------
Minor nit:
- function name to match null check?
- !s.isEmpty() compared to using s.length() > 0?
> TaskInfo in history parser should not depend on the apache directory project
> ----------------------------------------------------------------------------
>
> Key: TEZ-2749
> URL: https://issues.apache.org/jira/browse/TEZ-2749
> Project: Apache Tez
> Issue Type: Task
> Affects Versions: 0.8.0-alpha
> Reporter: Siddharth Seth
> Attachments: TEZ-2749.1.txt
>
>
> Uses
> import org.apache.directory.api.util.Strings;
> We should not be depending on this - especially for a Strings utility class.
> We also don't have an explicit dependency, assuming this comes in as a result
> of hadoop being pulled in.
> Appears to be in 0.8.0 only. (The class exists in api-util-1.0.0-M20.jar -
> pulled in by hadoop-auth)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
