[ 
https://issues.apache.org/jira/browse/TEZ-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717683#comment-14717683
 ] 

Hitesh Shah commented on TEZ-2662:
----------------------------------

bq. Do we need the class to be configurable ?

Fail-safe to avoid code changes down the line if we come across some weird 
conditions. Similar to the disable flag.

bq. Should gcOpts.put(opt, 1); be gcOpts.put(opt, val);

Switched to using a set. 

bq. Does a single - for a specific GC negate all + for the same ?
Yes - rightmost value wins. 

bq. One bit this will disallow is " -XX:+UseParNewGC -XX:+UseConcMarkSweepGC " 
- which can be specified together.

Addressed in upcoming patch. 



 

> Provide a way to check whether AM or task opts are valid and error if not 
> --------------------------------------------------------------------------
>
>                 Key: TEZ-2662
>                 URL: https://issues.apache.org/jira/browse/TEZ-2662
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-2662.1.patch, TEZ-2662.2.patch
>
>
> Current impl appends cmd-opts specified in config to programmatic opts 
> provided. This creates potential conflicts when using UseParallelGC v/s 
> UseG1GC 
> Tez should support a way to do checks for invalid java opts and error out as 
> needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to