[
https://issues.apache.org/jira/browse/TEZ-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723921#comment-14723921
]
TezQA commented on TEZ-2755:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12753335/TEZ-2755.1.patch
against master revision 5ba6cf9.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1046//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1046//console
This message is automatically generated.
> Fix findbugs warning in TezClient
> ---------------------------------
>
> Key: TEZ-2755
> URL: https://issues.apache.org/jira/browse/TEZ-2755
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: TEZ-2755.1.patch
>
>
> {code}
> Multithreaded correctness Warnings
> Code Warning
> SWL org.apache.tez.client.TezClient.stop() calls Thread.sleep() with a lock
> held
>
> Bug type SWL_SLEEP_WITH_LOCK_HELD (click for details)
> In class org.apache.tez.client.TezClient
> In method org.apache.tez.client.TezClient.stop()
> At TezClient.java:[line 584]
> Details
> SWL_SLEEP_WITH_LOCK_HELD: Method calls Thread.sleep() with a lock held
> This method calls Thread.sleep() with a lock held. This may result in very
> poor performance and scalability, or a deadlock, since other threads may be
> waiting to acquire the lock. It is a much better idea to call wait() on the
> lock, which releases the lock and allows other threads to run.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
