[ 
https://issues.apache.org/jira/browse/TEZ-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724621#comment-14724621
 ] 

Jeff Zhang commented on TEZ-2752:
---------------------------------

One minor concern about this change: this would mean the timestamp of the 
output failure is lost. (Could add another field for that)

\cc [~Sreenath] [~pramachandran] 
Here is the scenario.
* TaskAttemptStartedEvent --> TaskAttemptFinishedEvent (SUCCEEDED) -- 
TaskAttemptFinishedEvent (FAILED due to output failed/lost)

The change in this patch will make the timestamp when output failed happens 
lost. Not sure whether it would impact on the tez-ui if we need to visualize 
the timeline of one task attempt in the future. We could add another field to 
track the timestamp if you need that. Could you help confirm that ?


> logUnsuccessful completion in Attempt should write original finish time to ATS
> ------------------------------------------------------------------------------
>
>                 Key: TEZ-2752
>                 URL: https://issues.apache.org/jira/browse/TEZ-2752
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: TEZ-2752.1.patch
>
>
> Currently it overwrites with the current time and that results in wrong 
> information since in reality the attempt might have finished earlier if the 
> failure was output failure. Other failures also set the finish time in the 
> terminate transition and thus even in non output failed cases the value of 
> finishtime can be used instead of using current time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to