[
https://issues.apache.org/jira/browse/TEZ-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Eagles updated TEZ-2755:
---------------------------------
Attachment: TEZ-2755.2.patch
[~bikassaha], taking the same approach as waitTillReady which just defines the
findbugs exception. Since this is for stop, this may be an appropriate
accommodation.
> Fix findbugs warning in TezClient
> ---------------------------------
>
> Key: TEZ-2755
> URL: https://issues.apache.org/jira/browse/TEZ-2755
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: TEZ-2755.1.patch, TEZ-2755.2.patch
>
>
> {code}
> Multithreaded correctness Warnings
> Code Warning
> SWL org.apache.tez.client.TezClient.stop() calls Thread.sleep() with a lock
> held
>
> Bug type SWL_SLEEP_WITH_LOCK_HELD (click for details)
> In class org.apache.tez.client.TezClient
> In method org.apache.tez.client.TezClient.stop()
> At TezClient.java:[line 584]
> Details
> SWL_SLEEP_WITH_LOCK_HELD: Method calls Thread.sleep() with a lock held
> This method calls Thread.sleep() with a lock held. This may result in very
> poor performance and scalability, or a deadlock, since other threads may be
> waiting to acquire the lock. It is a much better idea to call wait() on the
> lock, which releases the lock and allows other threads to run.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
