[ 
https://issues.apache.org/jira/browse/TEZ-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737033#comment-14737033
 ] 

Hitesh Shah commented on TEZ-2792:
----------------------------------

Comments:
   - {code}import java.util.*;{code} - "*" should not be used.

   - What does "minId" signify? Why is there a dagMinId? All webservice calls 
should always be for only a specific dagId therefore why is there a need for 
minId? 
   - Also, what does minId mean for vertices and tasks? 
   - For getIntegersFromRequest() and  getMinIDsFromRequest(), how do you 
distinguish a request which says give me everything to one which had invalid 
paramters passed in? 

   - It seems checkAndGetDAGFromRequestMinID() and checkAndGetDAGFromRequest 
are similar except for the param name? Maybe the 2 can be combined? 

   - It might be better to set MAX_QUERIED to a higher value say 500 or 1000. 
The UI could be restricted to 100 or so but if the UI decides to change to a 
slightly higher value, the webservice then would not need to fixed. Maybe file 
a follow up jira for this value to be made configurable. 





> Add AM web service API for tasks.
> ---------------------------------
>
>                 Key: TEZ-2792
>                 URL: https://issues.apache.org/jira/browse/TEZ-2792
>             Project: Apache Tez
>          Issue Type: Sub-task
>          Components: UI
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>         Attachments: TEZ-2792.1.patch
>
>
> Add AM API for fetching realtime tasks info:
> - API endpoint : /ws/v2/tez/tasksInfo
> - Query Params:
> -- dagMinID: dagMinID = dagIndex, (mandatory).
> -- vertexMinID: A comma separated list. vertexMinID = vertexIndex.
> -- taskMinID: A comma separated list. taskMinID = vertexIndex_taskIndex
> -- limit: Maximum number of items to be returned (Defaults to 100).
> - If taskMinID is passed: All (capped by limit) the specified tasks will be 
> returned. vertexMinID if present wont be considered.
> - IF vertexMinID is passed: All (capped by limit) tasks under the vertices 
> will be returned.
> - If just dagID is passed: All (capped by limit) tasks under the DAG will be 
> returned.
> - Data returned: complete task id, progress, status



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to