[
https://issues.apache.org/jira/browse/TEZ-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744754#comment-14744754
]
TezQA commented on TEZ-1491:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755887/TEZ-1491.1.patch
against master revision ffa3d52.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.test.TestFaultTolerance
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1135//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/1135//artifact/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1135//console
This message is automatically generated.
> Tez reducer-side merge's counter update is slow
> -----------------------------------------------
>
> Key: TEZ-1491
> URL: https://issues.apache.org/jira/browse/TEZ-1491
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.6.0, 0.7.0, 0.8.0-alpha
> Reporter: Gopal V
> Assignee: Gopal V
> Labels: Performance
> Attachments: TEZ-1491.1.patch, perf-top-counters.png
>
>
> TezMerger$MergeQueue::next() shows up in profiles due a synchronized block in
> a tight loop.
> Part of the slow operation was due to DataInputBuffer issues identified
> earlier in HADOOP-10694, but along with that approx 11% of my lock prefix
> calls were originating from the following line.
> {code}
> mergeProgress.set(totalBytesProcessed * progPerByte);
> {code}
> in two places within the core loop.
> !perf-top-counters.png!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
