[
https://issues.apache.org/jira/browse/TEZ-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902024#comment-14902024
]
Siddharth Seth commented on TEZ-2716:
-------------------------------------
- Instead of calling sortAndSpill in a synchronzied block, it would be better
to only read the value of totalKeys inside a sync block, and then call
sortAndSpill outside the block.
- Does totalKeysProcessed in SpillThread need to be volatile. (Is set by the
main thread and read in the spill thread)
- The same handling required for sameKey ? I don't think this is modified under
any lock.
> DefaultSorter.isRleNeeded not thread safe
> -----------------------------------------
>
> Key: TEZ-2716
> URL: https://issues.apache.org/jira/browse/TEZ-2716
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Siddharth Seth
> Attachments: TEZ-2716.1.patch
>
>
> TEZ-1997.
> Should be targeted at the same set of versions that TEZ-1997 goes into.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
