[
https://issues.apache.org/jira/browse/TEZ-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907910#comment-14907910
]
Rajesh Balamohan commented on TEZ-2836:
---------------------------------------
lgtm +1.
Minor comment:
TestTaskExecution2.testMultipleSuccessfulTasks --> verifySysCounters() could be
simplified? "shouldBePresent" might not be needed if "minTaskCounterCount,
minFsCounterCount" are set as -1 (when counters are not present), so that
following asserts would be true.
>>
assertTrue(numTaskCounters >= minTaskCounterCount);
assertTrue(numFsCounters >= minFsCounterCount);
>>
> Avoid setting framework/system counters for tasks running in threads
> --------------------------------------------------------------------
>
> Key: TEZ-2836
> URL: https://issues.apache.org/jira/browse/TEZ-2836
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-2836.1.txt
>
>
> Counters like FileSystemCounters, GC_TIME, CPU_TIME etc - are computed
> incorrectly in case of LocalMode, Uber, TestService and others where tasks
> may execute in threads. (The values end up being a combination of what's
> running in the process - which could be other tasks or the AM).
> It's better not to set them for now, instead of reporting incorrect values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
