[
https://issues.apache.org/jira/browse/TEZ-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933734#comment-14933734
]
Hitesh Shah commented on TEZ-2758:
----------------------------------
Comments:
Mostly looks good.
bq. "throw new IOException("Summary file already exists, summaryPath:" +
summaryPath);"
Maybe just create summary stream object in the serviceStart() so that this path
is never used? ( this is optional - if not changed, please confirm that it ends
up in the RECOVERY_FATAL_OCCURRED_DIR creation path )
bq. throw new IOException("Recovery file already exists, recoveryPath:" +
dagFilePath);
Should we follow the "RECOVERY_FATAL_OCCURRED_DIR" approach if we encounter
this error? i.e. let processing continue but not recover if we hit an unknown
situation like this?
bq. assertFalse(recoveryService.outputStreamMap.containsKey(dagId));
Test ( testMultipleDAGFinishedEvent ) should contain atleast one assertTrue
check in addition to the checks that stream is closed and removed.
> Remove append API in RecoveryService after TEZ-1909
> ---------------------------------------------------
>
> Key: TEZ-2758
> URL: https://issues.apache.org/jira/browse/TEZ-2758
> Project: Apache Tez
> Issue Type: Improvement
> Affects Versions: 0.6.2
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2758-1.patch, TEZ-2758-2.patch
>
>
> After TEZ-1909, there would be no case for append recovery file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
