[ 
https://issues.apache.org/jira/browse/TEZ-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934053#comment-14934053
 ] 

Siddharth Seth commented on TEZ-2859:
-------------------------------------

Looks good. [~rajesh.balamohan] - to ensure I understand this correctly. The 
real merge thread is interrupted by the 'Interrupting Thread'. This doesn't 
show up as an exception in the main test thread - and instead causes the merge 
to exit early. Since the merge has exited early - the count should be > 1. With 
the patch, if the merge happens fast - the last closeOnDiskFile will be 
interrupted, and the final cleanup of structures won't happen ?

> TestMergeManager.testLocalDiskMergeMultipleTasks failing 
> ---------------------------------------------------------
>
>                 Key: TEZ-2859
>                 URL: https://issues.apache.org/jira/browse/TEZ-2859
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Priority: Blocker
>         Attachments: TEZ-2859.1.patch
>
>
> java.lang.AssertionError: Values should be different. Actual: 1
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failEquals(Assert.java:185)
>       at org.junit.Assert.assertNotEquals(Assert.java:161)
>       at org.junit.Assert.assertNotEquals(Assert.java:198)
>       at org.junit.Assert.assertNotEquals(Assert.java:209)
>       at 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager.testLocalDiskMergeMultipleTasks(TestMergeManager.java:432)
>       at 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager.testLocalDiskMergeMultipleTasks(TestMergeManager.java:192)
> https://builds.apache.org/job/Tez-Build/1259/testReport/junit/org.apache.tez.runtime.library.common.shuffle.orderedgrouped/TestMergeManager/testLocalDiskMergeMultipleTasks/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to