[ 
https://issues.apache.org/jira/browse/TEZ-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955874#comment-14955874
 ] 

Hitesh Shah commented on TEZ-2679:
----------------------------------

Comments: 
   - mostly looks good. 
   - there is a potential behaviour change being introduced by putting 
"NATIVE_LIB_PARAM_DEFAULT" into CLUSTER_DEFAULT and not the user default value. 
With earlier versions, NATIVE_LIB_PARAM_DEFAULT would have been overridden if 
the user default was setup. 

I think either approach should be fine but we should call it out as 
incompatible with a release note on the behavior change if the patch is not 
changed. 

> Admin forms of launch env settings
> ----------------------------------
>
>                 Key: TEZ-2679
>                 URL: https://issues.apache.org/jira/browse/TEZ-2679
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Jason Lowe
>            Assignee: Jonathan Eagles
>         Attachments: TEZ-2679.1.patch, TEZ-2679.2.patch
>
>
> Tez should provide corresponding admin configs for launch env and java opt 
> settings that can be specified in tez-site.xml by cluster admins.  For 
> example, if users override the launch env settings to setup LD_LIBRARY_PATH 
> to just reference their libs then we can fail to load the native Hadoop libs.
> This is currently mitigated by having Tez rely on the MapReduce admin 
> properties in many cases, but Tez should provide its own admin settings to 
> match the Tez-specific non-admin settings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to