[
https://issues.apache.org/jira/browse/TEZ-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955909#comment-14955909
]
Bikas Saha commented on TEZ-2882:
---------------------------------
Not looking in details since Sid's already reviewed.
MAX_ALLOWED_FAILED_FETCH_ATTEMPT_PERCENT & MIN_REQUIRED_PROGRESS_PERCENT are
still hard coded???
Please create jiras for new TODOs and reference them in the code. e.g. //TODO:
Consider removing reportReadErrorImmediately
hasIndividualAttemptExceeded() ??? Exceeded what? Its error message could be
improved (unrelated to this jira but useful to fix here). Also, would be useful
to consolidate the actual reporting of IOException to a common place. E.g. in
this method we do ioException.fillInStacktrace() but not in the other location.
> Consider improving fetch failure handling
> -----------------------------------------
>
> Key: TEZ-2882
> URL: https://issues.apache.org/jira/browse/TEZ-2882
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Rajesh Balamohan
> Assignee: Rajesh Balamohan
> Attachments: TEZ-2882.1.patch, TEZ-2882.2.patch, TEZ-2882.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
