[
https://issues.apache.org/jira/browse/TEZ-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959920#comment-14959920
]
Siddharth Seth commented on TEZ-1888:
-------------------------------------
Thanks for taking this up.
ContainerId.newInstance - this needs to be suppressed instead of changing it
over to use the new container. Tez still builds against Hadoop 2.2. Moving to
the new ContainerId creation method breaks the build.
As Hitesh mentioned, for DistCache - please add suppresswarnings again, instead
of changing to Job methods. This code hasn't been changed for a while - and
works. It'd be better to leave it as is.
There's a lot of changes which are unrelated to the patch - import oder is
changed, formatting changes, etc. Could you please remove these changes and
post a new patch. That makes it much simpler to review the patch, and avoids
conflicts when backports to other branches etc are required.
> Fix javac warnings all over codebase
> -------------------------------------
>
> Key: TEZ-1888
> URL: https://issues.apache.org/jira/browse/TEZ-1888
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Priority: Critical
> Attachments: TEZ-1888.1.patch
>
>
> As an example log, please look at:
> https://builds.apache.org/job/PreCommit-TEZ-Build/6//artifact/patchprocess/masterJavacWarnings.txt/*view*/
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
