[ 
https://issues.apache.org/jira/browse/TEZ-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986210#comment-14986210
 ] 

Hitesh Shah commented on TEZ-1974:
----------------------------------

Sorry for the delay in review. 

Not sure if this is entirely a correct fix. Consider the case where equals() 
can be invoked with either an MRCounter object or a TezCounter object. I think 
a simple approach might be to special case objects of these 2 types and compare 
to raw accordingly. Does that make sense? 



> Findbug warning: MRCounters$MRCounter.equals(Object) checks for operand being 
> a org.apache.tez.common.counters.TezCounter 
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-1974
>                 URL: https://issues.apache.org/jira/browse/TEZ-1974
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Chetna Chaudhari
>         Attachments: TEZ-1974.1.patch, TEZ-1974.2.patch
>
>
> Fix handling of TezCounters with MRCounters



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to