[
https://issues.apache.org/jira/browse/TEZ-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052360#comment-15052360
]
Jeff Zhang commented on TEZ-2990:
---------------------------------
Shouldn't use "-ff,--fail-fast" to bail out early regarding the mvn help ?
{code}
-fae,--fail-at-end Only fail the build afterwards;
allow all non-impacted builds to
continue
-ff,--fail-fast Stop at first failure in
reactorized builds
-fn,--fail-never NEVER fail the build, regardless
of project result
{code}
bq. -fn I believe results in an exit code of 0 - which should not matter.
At least I see the exit code is used in the following code, not sure about the
effect. [~hitesh] may know about this.
{code}
if [[ $test_build_result != 0 && -z "$module_failed_tests" && -z
"$module_test_timeouts" ]] ; then
failed_test_builds="$module $failed_test_builds"
fi
{code}
> test-patch bails out early if tests fails
> -----------------------------------------
>
> Key: TEZ-2990
> URL: https://issues.apache.org/jira/browse/TEZ-2990
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-2990.1.txt
>
>
> test-patch is making use of -fae -> which does not run tests on downstream
> modules if tests in an upstream module failed.
> Instead, we should be running -fn
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
