[
https://issues.apache.org/jira/browse/TEZ-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088348#comment-15088348
]
Siddharth Seth commented on TEZ-2669:
-------------------------------------
Thanks for taking a look [~zjffdu].
Have gotten rid of the duplication. I don't want to get rid of the
INTERNAL_ERROR sent out by the TaskScheduler in this patch - it's already very
big. Have created TEZ-3028 to track this. Likewise - there's an onError API on
the TaskSchedulerContext which doesn't exist on the other service plugins -
that needs to be a separate jira. TEZ-3029 for this.
bq. What's the purpose of
TaskCommunicatorWrapper/ContainerLauncherWrapper/TaskSchedulerWrapper ? Add
exception on methods ? We can do it on
TaskCommunicator/ContainerLauncher/TaskScheduler directly since the plugin api
is not stabilized yet I guess. Or maybe you don't want to make impact on
downstream project (hive) ?
>From my previous comment - The itnerfaces itself do not throw Exceptions - I
>don't think it's useful doing that since Tez can't take any useful action in
>such cases. This also forces the user code to look at possible Exceptions
>instead of just letting them filter through to the framework.
The Wrappers are a mechanism to force the framework to catch the Exceptions and
handle them correctly. There's tests to ensure the Wrappers throw Exceptions
for the relevant methods.
This patch actually breaks the interface by removing exceptions from
onVertexStateUpdated. The change is not to maintain compatibility - I don't
think it's useful having an Exception on the methods.
> Propagation of errors from plugins to the AM for error reporting
> ----------------------------------------------------------------
>
> Key: TEZ-2669
> URL: https://issues.apache.org/jira/browse/TEZ-2669
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: 0.8.0-alpha
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Priority: Blocker
> Attachments: TEZ-2669.1.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
