[
https://issues.apache.org/jira/browse/TEZ-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15099219#comment-15099219
]
TezQA commented on TEZ-2937:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12782375/TEZ-2937.1.patch
against master revision d0348b0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1424//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1424//console
This message is automatically generated.
> Can Processor.close() be called after closing inputs and outputs?
> -----------------------------------------------------------------
>
> Key: TEZ-2937
> URL: https://issues.apache.org/jira/browse/TEZ-2937
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Rohini Palaniswamy
> Attachments: TEZ-2937.1.patch
>
>
> Pig hit PIG-4722 as processor.close() which clears some static thread local
> variables was called when SpillThread was still running the Combiner.
> LogicalIOProcessorRuntimeTask.java calls processor.close() before closing the
> inputs and outputs in both close() and cleanup() methods. Can Tez change to
> closing the processor after the inputs and outputs are closed?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
