[ 
https://issues.apache.org/jira/browse/TEZ-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sreenath Somarajapuram updated TEZ-3101:
----------------------------------------
    Attachment: TEZ-3101.2.patch

Thanks [~hitesh]
Attaching a fresh patch with the comments addressed.

bq. Please clarify why the change in logs-cell.hbs is needed?
- Improved the comments for yarnProtocol, also moving it into configs.js as 
that gives better visibility

bq. isnt there an inbuilt javascript library api that can be leveraged instead 
of the manual parsing?
- Sorry that we don't have an inbuild inbuilt javascript library for parsing 
URL.

bq. What happens if RMWebUrl is specified without a preceding http://?
- Current UI protocol will be used.

bq. downloadUrl should not be changed...
- Have made the changes, the protocol will be applied only on inProgressLog

bq. Please clarify why the change in logs-cell.hbs is needed?
- The prepended "//" was for using the current UI protocol. Now as this is done 
from the javascript code this is not required, hence removing.

> Tez UI: Task attempt log link doesn't have the correct protocol
> ---------------------------------------------------------------
>
>                 Key: TEZ-3101
>                 URL: https://issues.apache.org/jira/browse/TEZ-3101
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>         Attachments: TEZ-3101.1.patch, TEZ-3101.2.patch
>
>
> - When inside ambari: Use protocol defined in yarn.http.policy configuration 
> to create the link. The value will be passed as a configuration by the Ambari 
> view code.
> - When running in standalone mode use the protocol in RM host URL.
> - Also ensure that the link is of the format 
> {code}http://foo.com:8042/node/containerlogs/<container_id>/<submitter>/syslog_<attempt_id>?user.name=<submitter>{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to