[
https://issues.apache.org/jira/browse/TEZ-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205796#comment-15205796
]
Hitesh Shah commented on TEZ-3173:
----------------------------------
Comments:
{code}
/**
76 * This time must be consent to the time logged by ATS
77 * The return value only make sense for successfully finished task;
otherwise it's -1
78 */
{code}
- Part of this comment makes more sense where finish time is being set and
not for the javadoc of a function. Function desc should describe what the
function is returning and not too much of implementation level details. Why
would -1 be returned for a failed or killed task?
{code}
// reportTaskStartTime is called by task to notify vertex its start time
public void reportTaskStartTime(long taskStartTime);
{code}
- use javadoc notation
- how does the vertex know which task id reported the start time? shouldnt it
take a taskId as a param?
Please fix function javadoc for getFinishTimeInternal() to explain what it is
and why it is different from getFinishTime()
{code}
@Override
1244 public void reportTaskStartTime(long taskStartTime) {
1245 writeLock.lock();
1246 if (firstTaskStartTime < 0 || firstTaskStartTime > taskStartTime) {
1247 firstTaskStartTime = taskStartTime;
1248 }
1249 writeLock.unlock();
1250 }
1251
{code}
- no try/finally?
{code}
void setLastTaskFinishTime() {
1925 for (Task task : tasks.values()) {
1926 if (task.getFinishTime() > this.lastTaskFinishTime) {
1927 this.lastTaskFinishTime = task.getFinishTime();
1928 }
1929 }
1930 }
{code}
- why is this not being set in constructFinalFullcounters() ?
Instead of {{vertex.getInitTime()+""}}, maybe use Long.toString()?
Recovery related:
- Check TaskImpl recoverData and how it is used. This might need additional
changes to add a call from TaskImpl to Vertex to report start time
> Update Tez AM REST APIs for more information for each vertex
> ------------------------------------------------------------
>
> Key: TEZ-3173
> URL: https://issues.apache.org/jira/browse/TEZ-3173
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Sreenath Somarajapuram
> Assignee: Zhiyuan Yang
> Attachments: TEZ-3173.1.patch
>
>
> `/ui/ws/v2/tez/verticesInfo` endpoint in WebUIService must be upgraded to
> send back the following fields
> # initTime
> # startTime
> # finishTime
> # firstTaskStartTime
> # lastTaskFinishTime
> in addition to the existing id, status, progress, totalTasks,
> succeededTasks, runningTasks, pendingTasks, failedTaskAttempts &
> killedTaskAttempts fields.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
