[ 
https://issues.apache.org/jira/browse/TEZ-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209342#comment-15209342
 ] 

Siddharth Seth commented on TEZ-3108:
-------------------------------------

bq. External services and local mode seems a bit confusing. If local mode is 
meant to signify that everything is running locally, then external services 
should not exist. If we are saying that only "yarn" containers are running 
inline in local mode then local mode should be renamed to something else?
Any suggestion on this. I'm looking at local mode as 1) no AM launched, 2) with 
service specified as 'container' - tasks will run inline.

bq. Havent reviewed patch fully - noticed that 
"Preconditions.checkState(foundUberServiceName);" should be outside the for 
loop?
Yes. This should be outside. Will move it out in the next patch, along with 
other forthcoming review comments.

> Add support for external services to local mode
> -----------------------------------------------
>
>                 Key: TEZ-3108
>                 URL: https://issues.apache.org/jira/browse/TEZ-3108
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-3108.1.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to