[
https://issues.apache.org/jira/browse/TEZ-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220953#comment-15220953
]
TezQA commented on TEZ-3192:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12796422/TEZ-3192.1.patch
against master revision e416991.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in :
org.apache.tez.test.TestRecovery
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1601//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1601//console
This message is automatically generated.
> IFile#checkState creating unnecessary objects though auto-boxing
> ----------------------------------------------------------------
>
> Key: TEZ-3192
> URL: https://issues.apache.org/jira/browse/TEZ-3192
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Fix For: 0.7.1, 0.8.3
>
> Attachments: TEZ-3192.1.patch
>
>
> checkState is a varargs function which takes Objects. ints and longs create
> unnecessary Integers and Long objects through Integer.valueOf and
> Long.valueOf. This is used in the read key and read value loop so while
> small, puts this on par with the MR equivalent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
