[
https://issues.apache.org/jira/browse/TEZ-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256846#comment-15256846
]
Bikas Saha commented on TEZ-3219:
---------------------------------
Is there any issue in having the YARN based plugins provide the existing info
via the new APIs instead of special casing them in the core code. This way the
handling of all plugins is identical and makes the flow consistent and better
for debugging and other issues.
{code}- if (containerId != null && nodeHttpAddress != null) {
- final String containerIdStr = containerId.toString();
- inProgressLogsUrl = nodeHttpAddress
- + "/" + "node/containerlogs"
- + "/" + containerIdStr
- + "/" + this.appContext.getUser();
+ if (getVertex().getServicePluginInfo().getContainerLauncherName().equals(
+ TezConstants.getTezYarnServicePluginName())
+ ||
getVertex().getServicePluginInfo().getContainerLauncherName().equals(
+ TezConstants.getTezUberServicePluginName())) {
+ if (containerId != null && nodeHttpAddress != null) {
+ final String containerIdStr = containerId.toString();
+ inProgressLogsUrl = nodeHttpAddress
+ + "/" + "node/containerlogs"
+ + "/" + containerIdStr
+ + "/" + this.appContext.getUser();
+ }
+ } else {
+ inProgressLogsUrl =
appContext.getTaskCommunicatorManager().getInProgressLogsUrl(
+ getVertex().getTaskCommunicatorIdentifier(),
+ attemptId, containerNodeId);
}{code}
> Allow service plugins to define log locations link for remotely run task
> attempts
> ----------------------------------------------------------------------------------
>
> Key: TEZ-3219
> URL: https://issues.apache.org/jira/browse/TEZ-3219
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Fix For: 0.9.0, 0.8.4
>
> Attachments: TEZ-3219.1.patch, TEZ-3219.2.patch, TEZ-3219.3.patch,
> TEZ-3219.4.patch, TEZ-3219.5.patch
>
>
> Today log links are generated based on the assumption that they are running
> in yarn containers. For LLAP-like service plugin runs, the log links are
> incorrect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
