[
https://issues.apache.org/jira/browse/TEZ-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279252#comment-15279252
]
TezQA commented on TEZ-3250:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12803309/TEZ-3250.1.patch
against master revision 50ea2de.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1712//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1712//console
This message is automatically generated.
> TezTaskRunner2 should not accept ListeningExecutorService
> ---------------------------------------------------------
>
> Key: TEZ-3250
> URL: https://issues.apache.org/jira/browse/TEZ-3250
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.8.3, 0.9.0
> Reporter: Prasanth Jayachandran
> Assignee: Prasanth Jayachandran
> Attachments: TEZ-3250.1.patch
>
>
> TezTaskRunner2 currently accepts ListeningExecutorService. Also it is not
> making use of the callback listener feature of ListeningExecutorService. It
> should instead accept the base ExecutorService.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
