[
https://issues.apache.org/jira/browse/TEZ-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299317#comment-15299317
]
TezQA commented on TEZ-3257:
----------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12806032/TEZ-3257.patch
against master revision 2ecef25.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1750//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1750//console
This message is automatically generated.
> Flaky TestUnorderedPartitionedKVWriter
> --------------------------------------
>
> Key: TEZ-3257
> URL: https://issues.apache.org/jira/browse/TEZ-3257
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: TEZ-3257.patch
>
>
> For example,
> {noformat}
> testSkippedPartitions[1](org.apache.tez.runtime.library.common.writers.TestUnorderedPartitionedKVWriter)
> Time elapsed: 0.346 sec <<< FAILURE!
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.tez.runtime.library.common.writers.TestUnorderedPartitionedKVWriter.baseTest(TestUnorderedPartitionedKVWriter.java:661)
> at
> org.apache.tez.runtime.library.common.writers.TestUnorderedPartitionedKVWriter.testSkippedPartitions(TestUnorderedPartitionedKVWriter.java:196)
> {noformat}
> The reason is the spill onSuccess callback can happen between the following
> two lines, which means the old buffer will be added to {{availableBuffers}}
> in time and thus there is no need to initialize another buffer.
> {noformat}
> ListenableFuture<SpillResult> future = spillExecutor.submit(
> new SpillCallable(currentBuffer, codec, spilledRecordsCounter,
> spillPathDetails));
> Futures.addCallback(future, new
> SpillCallback(spillPathDetails.spillIndex));
> WrappedBuffer wb = getNextAvailableBuffer();
> {noformat}
> Can we just remove the following check in test code?
> {noformat}
> // Verify the status of the buffers
> if (numExpectedSpills == 0) {
> assertEquals(1, kvWriter.numInitializedBuffers);
> } else {
> assertTrue(kvWriter.numInitializedBuffers > 1);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
