[
https://issues.apache.org/jira/browse/TEZ-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302663#comment-15302663
]
Hitesh Shah commented on TEZ-3267:
----------------------------------
Comments:
{code}
private void updateQueueName(DAGRecoveryData recoveredDAGData) {
913 if (recoveredDAGData.recoveredDAG != null) {
914 String queueName =
recoveredDAGData.recoveredDAG.getSubmittedQueueName();
915 if (recoveredDAGData.getDAGFinishedEvent() != null) {
916 queueName =
recoveredDAGData.getDAGFinishedEvent().getQueueName();
917 } else if (recoveredDAGData.getDAGStartedEvent() != null) {
918 queueName =
recoveredDAGData.getDAGStartedEvent().getQueueName();
919 } else if (recoveredDAGData.getDAGInitializedEvent() != null) {
920 queueName =
recoveredDAGData.getDAGInitializedEvent().getQueueName();
921 }
922 if (queueName != null) {
923 recoveredDAGData.recoveredDAG.setSubmittedQueueName(queueName);
924 }
925 }
926 }
{code}
- I am not sure why getting the queue name needs to be this complex. I would
assume that queue name will only be persisted to recovery only for the
submitted event. Why do all events need to store the same info? All events do
need queue name for history logging but not necessarily use it in recovery.
ATSHistoryLoggingService.java has spurious changes.
Queue name should also be added to other info in the history data.
HistoryEventJsonConversion should also be changed. Likewise for its tests.
Code line length limit is a 100. In future, line wrap changes such as ones for
"TimelineEntity timelineEntity =
HistoryEventTimelineConversion.convertToTimelineEntity(event);" should not be
done unless they are over the length limit.
> Allow dag to be searchable by queue name.
> -----------------------------------------
>
> Key: TEZ-3267
> URL: https://issues.apache.org/jira/browse/TEZ-3267
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Harish Jaiprakash
> Assignee: Harish Jaiprakash
> Attachments: TEZ-3267.0.patch, TEZ-3267.1.patch
>
>
> Use submission queue info from YARN to update ATS data for dag to allow
> searches by queue name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
