[
https://issues.apache.org/jira/browse/TEZ-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304338#comment-15304338
]
Hitesh Shah edited comment on TEZ-3267 at 5/27/16 4:56 PM:
-----------------------------------------------------------
Comments:
{noformat} // FIXME: Replace this with constant once the yarn patch is
backported. (JIRA:) {noformat}
- jira id?
{code}
public void setSubmittedQueueName(String submittedQueueName) {
1440 this.submittedQueueName = submittedQueueName;
1441 }
{code}
- any reason this field is not a final field and initialized via the
constructor?
DAGFinishedEvent - why does the proto need to be changed for queue name?
Likewise for DAGStartedEvent and DAGInitializedEvent ?
DAGFinishedEvent::toString - lets put queueName before counters for easy
parsing. Please file a bug for the swimlanes parser to be fixed for this.
HistoryEvents.proto changes - see above comments for different event types.
I think the history parser used by the analyers also needs to be changed to
incorporate the queue info into the dag info. \cc [~rajesh.balamohan]. This can
be done in a follow-up jira.
was (Author: hitesh):
Comments:
{{ // FIXME: Replace this with constant once the yarn patch is backported.
(JIRA:) }}
- jira id?
{code}
public void setSubmittedQueueName(String submittedQueueName) {
1440 this.submittedQueueName = submittedQueueName;
1441 }
{code}
- any reason this field is not a final field and initialized via the
constructor?
DAGFinishedEvent - why does the proto need to be changed for queue name?
Likewise for DAGStartedEvent and DAGInitializedEvent ?
DAGFinishedEvent::toString - lets put queueName before counters for easy
parsing. Please file a bug for the swimlanes parser to be fixed for this.
HistoryEvents.proto changes - see above comments for different event types.
I think the history parser used by the analyers also needs to be changed to
incorporate the queue info into the dag info. \cc [~rajesh.balamohan]. This can
be done in a follow-up jira.
> Allow dag to be searchable by queue name.
> -----------------------------------------
>
> Key: TEZ-3267
> URL: https://issues.apache.org/jira/browse/TEZ-3267
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Harish Jaiprakash
> Assignee: Harish Jaiprakash
> Attachments: TEZ-3267.0.patch, TEZ-3267.1.patch, TEZ-3267.2.patch
>
>
> Use submission queue info from YARN to update ATS data for dag to allow
> searches by queue name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
