[ 
https://issues.apache.org/jira/browse/TEZ-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352204#comment-15352204
 ] 

Tsuyoshi Ozawa commented on TEZ-3313:
-------------------------------------

Thanks [~rajesh.balamohan] for your contribution.

I have 2 comments:

1. What's the difference between revision and version? We should write it down 
on docs.
2. Why not making the order of arguments for constructors same as 
org.apache.tez.common.VersionInfo?  (String version, String revision, String 
buildTime) looks to be better since it's more consistent with 
org.apache.tez.common.VersionInfo.

Thoughts?




> ATSFileParser : Wrong args passed in VersionInfo
> ------------------------------------------------
>
>                 Key: TEZ-3313
>                 URL: https://issues.apache.org/jira/browse/TEZ-3313
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>            Priority: Minor
>         Attachments: TEZ-3313.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to