[
https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389988#comment-15389988
]
Hitesh Shah commented on TEZ-3359:
----------------------------------
Comments:
- findbugs warning to be addressed.
- logLevel.toUpperCase() should use a locale I believe.
- validateLogLevel() is never called. I believe this should be called in tez
client during app submission to check the am setting and at dag submission to
check the dag level correctness ( the latter can be done in DAG::verify/build I
believe)
{code}
68 } catch (IllegalArgumentException e) {
69 return false;
70 }
{code}
- please add a log message here.
TezConf javadocs for history log level should mention the default value and
therefore reference HistoryLogLevel.DEFAULT as the actual default value in use.
{code}
} catch (IllegalArgumentException e) {
55 LOG.warn("Invalid value found for conf: " +
TezConfiguration.TEZ_HISTORY_LOGLEVEL +
56 ", value: " + logLevel);
57 return defaultValue;
58 }
{code}
- once checks are added in the client, this exception should never get
triggered - correct?
> Add granular log levels for HistoryLoggingService.
> --------------------------------------------------
>
> Key: TEZ-3359
> URL: https://issues.apache.org/jira/browse/TEZ-3359
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Harish Jaiprakash
> Assignee: Harish Jaiprakash
> Attachments: TEZ-3359.01.patch, TEZ-3359.02.patch
>
>
> We publish too many events to ATS, this increases the file size for ATS.
> Reduce data size logged into ATS by:
> * Having a more granular control over the loglevel, disable task level logs,
> or all logs and so on.
> * Disable logging counters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
