[
https://issues.apache.org/jira/browse/TEZ-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450205#comment-15450205
]
Hitesh Shah commented on TEZ-3326:
----------------------------------
YARN-4309 I believe is the one which today logs the contents of the launch
script, etc. It does not log all the details required as part of this jira.
bq. Would we want to get rid of changes down in downstream projects and
reimplement them together unified in YARN or would we just make this the
standard "from now on"
I would assume that downstream projects should not change atleast initially and
for some period, both YARN and the app would do some duplicate logging. Over
time as the feature stabilizes and becomes default enabled with the required
configs, the apps could change to disable their internal logging.
In any case, for this particular patch, I think we can push it into Tez in any
case as YARN does not have the full required functionality today.
Some comments on the patch before it is ready to commit:
- minor nit: helper function belongs to TezUtils or TezCommonUtils - dont
believe if it is related to YARN.
- was the main reason of the function returning a string instead of logging
directly to log as part of the callee class and also to aid unit testing? The
function could easily be changed to do the conf parsing and the logging? Just
curious about the reason - code does not need to change.
- Should we be using system.out to log this info to ensure that it always
gets logged e.g for some reason log4j props is misconfigured or log level set
to error?
- conf.getStrings() as compared to conf.get() ?
> Display JVM system properties in AM and task logs
> -------------------------------------------------
>
> Key: TEZ-3326
> URL: https://issues.apache.org/jira/browse/TEZ-3326
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Ming Ma
> Assignee: Eric Badger
> Attachments: TEZ-3326.001.patch, TEZ-3326.002.patch,
> TEZ-3326.003.patch
>
>
> MapReduce displays JVM system properties via config
> {{mapreduce.jvm.system-properties-to-log}} in both AM and task log . This is
> useful to debug env setting such as java version, etc. It is useful to have
> such logging in Tez.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
