[ 
https://issues.apache.org/jira/browse/TEZ-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497161#comment-15497161
 ] 

TezQA commented on TEZ-3430:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12828869/TEZ-3430.patch
  against master revision b17edc4.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.tez.dag.app.rm.TestContainerReuse

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1971//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1971//console

This message is automatically generated.

> Make split sorting optional
> ---------------------------
>
>                 Key: TEZ-3430
>                 URL: https://issues.apache.org/jira/browse/TEZ-3430
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: TEZ-3430.patch
>
>
> The fair routing design in TEZ-3209 addresses the skewed partitions where one 
> partition could be much larger than the others. But to simplify the stats 
> tracking, it assumes a given partition's data is distributed evenly to some 
> degree across source tasks so that it can group consecutive source tasks 
> together.
> However, this assumption is invalid given {{MRInputHelpers}}'s 
> generateNewSplits and generateOldSplits sort the splits by size, thus the 
> data size in the beginning of source task range is bigger than that of at the 
> end.
> {noformat}
> Arrays.sort(splits, new InputSplitComparator());
> {noformat}
> One way to fix this is to have fair routing track not only the aggregated 
> size of each partition, but also the size of each partition of each source 
> task. But that will significantly increase the memory footprint.
> Alternatively, it can skip the sorting above. Test results for TEZ-3209 show 
> that jobs can finish 30% faster, given the source tasks output size is more 
> balanced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to