Kuhu Shukla updated TEZ-3437:
    Attachment: TEZ-3437.004.patch

Addressed some of the review comments, the following one still remains.
Individual inputs don't need to throw the Exception. The question was really 
around why IOException and InterruptedException. I'd change this to either 
Exception - similar to the other methods (but not very useful), or 
InterruptedException + a TezCheckedException or a custom 
ProgressFailedException. Anyone else has thoughts on this? Processors may want 
to handle this, hence a checked Exception.

> Improve synchronization and the progress report behavior for Inputs from 
> TEZ-3317
> ---------------------------------------------------------------------------------
>                 Key: TEZ-3437
>                 URL: https://issues.apache.org/jira/browse/TEZ-3437
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>         Attachments: TEZ-3437.001.patch, TEZ-3437.002.patch, 
> TEZ-3437.003.patch, TEZ-3437.004.patch
> Follow up from TEZ-3317 to improve the getProgress thread synchronization and 
> replace timerTasks with ScheduledExecutorService. 

This message was sent by Atlassian JIRA

Reply via email to