[
https://issues.apache.org/jira/browse/TEZ-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510238#comment-15510238
]
Hitesh Shah edited comment on TEZ-3432 at 9/21/16 8:49 PM:
-----------------------------------------------------------
Comments:
- bunch of copy paste errors related to TestMRRJobs need to be fixed. Also,
any reason on why we need a new test file launching a new minicluster instead
of adding to one of the existing test files?
- reference to MRAppJar - what is this for?
- the test verifies that the session shut down but it does not really check
that the session shuts down due to the timeout. Please take a look at TEZ-3405
and maybe consider pulling out the tests and functionality changes from that
patch if required to actually verify the functionality.
- the test is timing dependent - was this run 50-100 times in a row to
verify that it is not flaky?
- why does
"conf.setInt(TezConfiguration.TEZ_SESSION_AM_DAG_SUBMIT_TIMEOUT_SECS, 5);" need
to be setup at the cluster config level and not at the session level?
was (Author: hitesh):
Comments:
- bunch of copy paste errors related to TestMRRJobs need to be fixed.
- reference to MRAppJar - what is this for?
- the test verifies that the session shut down but it does not really check
that the session shuts down due to the timeout. Please take a look at TEZ-3405
and maybe consider pulling out the tests and functionality changes from that
patch if required to actually verify the functionality.
- the test is timing dependent - was this run 50-100 times in a row to
verify that it is not flaky?
- why does
"conf.setInt(TezConfiguration.TEZ_SESSION_AM_DAG_SUBMIT_TIMEOUT_SECS, 5);" need
to be setup at the cluster config level and not at the session level?
> Add unit test for session timeout
> ---------------------------------
>
> Key: TEZ-3432
> URL: https://issues.apache.org/jira/browse/TEZ-3432
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Sushmitha Sreenivasan
> Assignee: Sreenath Somarajapuram
> Labels: newbie
> Attachments: TEZ-3432.1.patch
>
>
> Add unit test which sets tez.session.am.dag.submit.timeout.secs to say 5 secs
> and checking if dag submission timeouts after the configured time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
