[
https://issues.apache.org/jira/browse/TEZ-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534554#comment-15534554
]
TezQA commented on TEZ-3453:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12831002/16.patch
against master revision 5c2f893.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1996//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1996//console
This message is automatically generated.
> Correct the downloaded ATS dag data location for analyzer
> ---------------------------------------------------------
>
> Key: TEZ-3453
> URL: https://issues.apache.org/jira/browse/TEZ-3453
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Dharmesh Kakadia
> Priority: Minor
> Attachments: 16.patch, TEZ-3453.1.patch
>
>
> hadoop jar /usr/hdp/current/tez-client/tez-job-analyzer-*.jar CriticalPath
> --dagId=dag_1475171170456_0002_1 --outputDir=tmp/
> fails with
> INFO history.ATSImportTool: Using
> baseURL=http://headnodehost:8188/ws/v1/timeline,
> dagId=dag_1475171170456_0002_1, batchSize=100, downloadDir=tmp
> java.lang.IllegalArgumentException: Zipfile
> tmp/dag_1475171170456_0002_1/dag_1475171170456_0002_1.zip does not exist
> at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
> at org.apache.tez.history.parser.ATSFileParser.(ATSFileParser.java:65)
> at
> org.apache.tez.analyzer.plugins.TezAnalyzerBase.run(TezAnalyzerBase.java:169)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
> at
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.main(CriticalPathAnalyzer.java:653)
> The code is incorrectly expecting it to be in
> subfolder(dag_1475171170456_0002_1/dag_1475171170456_0002_1.zip). Moving the
> downloaded data location to the subfolder fixes the issue. This PR corrects
> the expected path.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
