[ 
https://issues.apache.org/jira/browse/TEZ-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573308#comment-15573308
 ] 

Hitesh Shah commented on TEZ-3432:
----------------------------------

Looks good. +1. 

Minor comment on: 

{code}
      Assert.assertTrue("AM didn't timeout in the expected time!" +
1051                  " AM Shutdown Time:" + 
dateFormatter.format(amShutdownTime) +
1052                  " Last DAG Completion Time:" + 
dateFormatter.format(lastDAGCompletionTime),
1053              (amShutdownTime - lastDAGCompletionTime) < 6000); //Testing 
with 20% buffer
{code}

This might be something to keep an eye in the future to ensure that it is not 
flaky on low-cpu VMs. 

> Add unit test for session timeout
> ---------------------------------
>
>                 Key: TEZ-3432
>                 URL: https://issues.apache.org/jira/browse/TEZ-3432
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Sushmitha Sreenivasan
>            Assignee: Sreenath Somarajapuram
>              Labels: newbie
>         Attachments: TEZ-3432.1.patch, TEZ-3432.2.patch, TEZ-3432.3.patch, 
> TEZ-3432.4.patch, TEZ-3432.5.patch
>
>
> Add unit test which sets tez.session.am.dag.submit.timeout.secs to say 5 secs 
> and checking if dag submission timeouts after the configured time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to