[
https://issues.apache.org/jira/browse/TEZ-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602852#comment-15602852
]
Sreenath Somarajapuram edited comment on TEZ-3471 at 10/24/16 11:57 PM:
------------------------------------------------------------------------
bq. profile id names should ideally not contain spaces.
- Thanks, will give another patch.
bq. What happens when doing -Dmaven.test.skip=true?
- Must add it to activation list.
Is there a reason why the em-* dependencies are not ranges but hardcoded to a
single version that needs to be changed each time around? Are these libraries
changing in an incompatible way across each version?
- Felt that fixing the version might be a better option as it ensures that the
behavior stays constant. For instance TEZ-3428. That is a harmless change. But
if old UIs had a range, and if any of the tests were using the old 'First'
button. Just this behavior change is enough to break the test for old releases
or their maintenance releases.
was (Author: sreenath):
bq. profile id names should ideally not contain spaces.
- Thanks, will give another patch.
bq. What happens when doing -Dmaven.test.skip=true?
- Must add it to activation list.
Is there a reason why the em-* dependencies are not ranges but hardcoded to a
single version that needs to be changed each time around? Are these libraries
changing in an incompatible way across each version?
- Felt that fixing the version might be a better option as it ensures that the
behavior stays constant. For instance TEZ-3428. That is a harmless change. But
if old UIs had a range, and if any of the STs were using the old 'First'
button. Just this behavior change is enough to break the test for old releases
or their maintenance releases.
> Tez UI: PhantomJS dependency should be downloaded only when tests are run
> -------------------------------------------------------------------------
>
> Key: TEZ-3471
> URL: https://issues.apache.org/jira/browse/TEZ-3471
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Sreenath Somarajapuram
> Assignee: Sreenath Somarajapuram
> Labels: TezUI
> Attachments: TEZ-3471.1.patch
>
>
> - PhantomJS is the most heavy dependency in TezUI. Its a headless browser for
> running UTs.
> - Right now its downloaded in all builds, when they are required only when
> tests are run.
> - This ticket is to disable downloading of PhantomJS when build is run with
> -DskipTests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
