[
https://issues.apache.org/jira/browse/TEZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611904#comment-15611904
]
Jason Lowe commented on TEZ-3097:
---------------------------------
bq. Is this a bug? Should we handle case where dag can be finished before the
above schedule is done.
I don't think it's a bug. If the DAG believes it is complete and ready to
commit, then why are we just getting around to telling a vertex manager that
the vertex started and it should start scheduling tasks? I think this is an
artifact of the test trying to fake the completion of the DAG.
For the purposes of this test, I suspect the concurrent queue fix would work
since it's not interested in task-level events. It only cares about commit
events and dag completion events, and those appear to be issued synchronously
with the direct handler invocation.
> Flaky test: TestCommit.testDAGCommitStartedEventFail_OnDAGSuccess
> -----------------------------------------------------------------
>
> Key: TEZ-3097
> URL: https://issues.apache.org/jira/browse/TEZ-3097
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.8.3
> Reporter: Jeff Zhang
> Assignee: Harish Jaiprakash
>
> {noformat}
> testDAGCommitStartedEventFail_OnDAGSuccess(org.apache.tez.dag.app.dag.impl.TestCommit)
> Time elapsed: 0.072 sec <<< ERROR!
> java.util.ConcurrentModificationException: null
> at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:859)
> at java.util.ArrayList$Itr.next(ArrayList.java:831)
> at
> org.apache.tez.dag.app.dag.impl.TestCommit$MockHistoryEventHandler.verifyVertexCommitStartedEvent(TestCommit.java:2033)
> at
> org.apache.tez.dag.app.dag.impl.TestCommit.testDAGCommitStartedEventFail_OnDAGSuccess(TestCommit.java:1880)
> {noformat}
> https://builds.apache.org/job/Tez-Build-Hadoop-2.4/245/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
